Validate checkedExceptionClasses config#3987
Open
janedbal wants to merge 4 commits intophpstan:2.1.xfrom
Open
Conversation
janedbal
commented
May 12, 2025
ondrejmirtes
requested changes
Jul 17, 2025
ondrejmirtes
requested changes
Aug 30, 2025
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
And fix the conflicts please 😊
Validate that class names configured in checkedExceptionClasses and uncheckedExceptionClasses actually exist, preventing silent misconfiguration. Gated behind bleedingEdge feature toggle. Also removes non-existent exception classes from build/phpstan.neon. Co-Authored-By: Claude Code
janedbal
force-pushed
the
checked-exceptions-validate-config
branch
from
1986cf0 to
4c17d37
Compare
The validation happens in ContainerFactory::create(), not in DefaultExceptionTypeResolver's constructor. Tests construct DefaultExceptionTypeResolver directly, so they are unaffected. Co-Authored-By: Claude Code
ReflectionProvider needs BetterReflection to be initialized before it can resolve classes. This happens in postInitializeContainer. Co-Authored-By: Claude Code
DerivativeContainerFactory creates secondary containers (e.g. for stub validation) that have different source locators. These containers set __validate to false, so use the same guard as validateParameters. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.